x86/amd_nb: Fix boot crash on non-AMD systems
authorBorislav Petkov <bp@suse.de>
Thu, 16 Jun 2016 17:13:49 +0000 (19:13 +0200)
committerIngo Molnar <mingo@kernel.org>
Fri, 1 Jul 2016 07:35:35 +0000 (09:35 +0200)
commit1ead852dd88779eda12cb09cc894a03d9abfe1ec
tree54ac3a80addab9db944052d1a31f539d7eb0924a
parent8d950d2fb23b696d393020486ab6a350bcb2c582
x86/amd_nb: Fix boot crash on non-AMD systems

Fix boot crash that triggers if this driver is built into a kernel and
run on non-AMD systems.

AMD northbridges users call amd_cache_northbridges() and it returns
a negative value to signal that we weren't able to cache/detect any
northbridges on the system.

At least, it should do so as all its callers expect it to do so. But it
does return a negative value only when kmalloc() fails.

Fix it to return -ENODEV if there are no NBs cached as otherwise, amd_nb
users like amd64_edac, for example, which relies on it to know whether
it should load or not, gets loaded on systems like Intel Xeons where it
shouldn't.

Reported-and-tested-by: Tony Battersby <tonyb@cybernetics.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: <stable@vger.kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1466097230-5333-2-git-send-email-bp@alien8.de
Link: https://lkml.kernel.org/r/5761BEB0.9000807@cybernetics.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/amd_nb.c