team: fix releasing uninitialized pointer to BPF prog
authorDaniel Borkmann <dborkman@redhat.com>
Thu, 31 Jul 2014 19:48:59 +0000 (21:48 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 31 Jul 2014 20:10:02 +0000 (13:10 -0700)
commit2b391ee2cae3945832011970bede35dab885879d
treef3f2420c980c5459041261bad7c72325642025cd
parentccda4a77f3a5976e4f064eddce11faec54d1f1e0
team: fix releasing uninitialized pointer to BPF prog

Commit 34c5bd66e5ed introduced the possibility that an
uninitialized pointer on the stack (orig_fp) can call into
sk_unattached_filter_destroy() when its value is non NULL.

Before that commit orig_fp was only destroyed in the same
block where it was assigned a valid BPF prog before. Fix it
up by initializing it to NULL.

Fixes: 34c5bd66e5ed ("net: filter: don't release unattached filter through call_rcu()")
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Cc: Pablo Neira <pablo@netfilter.org>
Cc: Alexei Starovoitov <ast@plumgrid.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/team/team_mode_loadbalance.c