projects / cascardo / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: f7a1dd6) | patch
net: mac802154: comparision issue of type cast, finding by EXTRA_CFLAGS=-W
authorChen Gang <gang.chen@asianux.com>
Thu, 25 Apr 2013 00:49:55 +0000 (00:49 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 29 Apr 2013 16:29:04 +0000 (12:29 -0400)
commit2c1bbbffa0b644fab4f91878cde0c2e8f52e2dcc
tree2b9efab1d5155c58fe2fb76116ec01f1df64161dtree | snapshot
parentf7a1dd6e3ad59f0cfd51da29dfdbfd54122c5916commit | diff
net: mac802154: comparision issue of type cast, finding by EXTRA_CFLAGS=-W

Change MAC802154_CHAN_NONE from ~(u8)0 to 0xff, or the comparison in
mac802154_wpan_xmit() for ``chan == MAC802154_CHAN_NONE'' will not
succeed.

This bug can be boiled down to ``u8 foo = 0xff; if (foo == ~(u8)0)
[...] else [...]'' where the condition will always take the else
branch.

Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mac802154/mac802154.h diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.