dmaengine: edma: avoid uninitialized variable use
authorArnd Bergmann <arnd@arndb.de>
Fri, 30 Sep 2016 16:19:01 +0000 (18:19 +0200)
committerVinod Koul <vinod.koul@intel.com>
Fri, 30 Sep 2016 17:46:35 +0000 (23:16 +0530)
commit2cc40ee7ae30fa12c3ee3f18e6c0e81cced2cdcc
tree4c7b6b93bf9f3447c839d2266e8f97b2ce60628c
parent3a03ea763a675ecb2a8805c6db01af125daa56e4
dmaengine: edma: avoid uninitialized variable use

If edma_read_slot() gets an invalid argument, it does not set a result,
as found by "gcc -Wmaybe-uninitialized"

drivers/dma/edma.c: In function 'dma_ccerr_handler':
drivers/dma/edma.c:1499:21: error: 'p.a_b_cnt' may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/dma/edma.c:1499:21: error: 'p.ccnt' may be used uninitialized in this function [-Werror=maybe-uninitialized]
  if (p.a_b_cnt == 0 && p.ccnt == 0) {

If we change the function to return an error in this case, we can handle
the failure more gracefully and treat this the same way as a null slot
that we already catch.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/edma.c