lib: proportion: lower PROP_MAX_SHIFT to 32 on 64-bit kernel
authorWu Fengguang <fengguang.wu@intel.com>
Mon, 9 Jan 2012 17:53:50 +0000 (11:53 -0600)
committerWu Fengguang <fengguang.wu@intel.com>
Wed, 1 Feb 2012 08:53:46 +0000 (16:53 +0800)
commit3310225dfc71a35a2cc9340c15c0e08b14b3c754
tree0475693eddb964dd8ea125e59f9e9efbcabd1dd0
parent15eb77a07c714ac80201abd0a9568888bcee6276
lib: proportion: lower PROP_MAX_SHIFT to 32 on 64-bit kernel

PROP_MAX_SHIFT should be set to <=32 on 64-bit box. This fixes two bugs
in the below lines of bdi_dirty_limit():

bdi_dirty *= numerator;
do_div(bdi_dirty, denominator);

1) divide error: do_div() only uses the lower 32 bit of the denominator,
   which may trimmed to be 0 when PROP_MAX_SHIFT > 32.

2) overflow: (bdi_dirty * numerator) could easily overflow if numerator
   used up to 48 bits, leaving only 16 bits to bdi_dirty

Cc: <stable@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Reported-by: Ilya Tumaykin <librarian_rus@yahoo.com>
Tested-by: Ilya Tumaykin <librarian_rus@yahoo.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
include/linux/proportions.h