virtio-net: refill only when device is up during setting queues
authorJason Wang <jasowang@redhat.com>
Tue, 15 Oct 2013 03:18:59 +0000 (11:18 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 17 Oct 2013 19:53:09 +0000 (15:53 -0400)
commit35ed159bfd96a7547ec277ed8b550c7cbd9841b6
tree08d5bade9d21d2457bcc1e19651b16106cafc582
parent3ab098df35f8b98b6553edc2e40234af512ba877
virtio-net: refill only when device is up during setting queues

We used to schedule the refill work unconditionally after changing the
number of queues. This may lead an issue if the device is not
up. Since we only try to cancel the work in ndo_stop(), this may cause
the refill work still work after removing the device. Fix this by only
schedule the work when device is up.

The bug were introduce by commit 9b9cd8024a2882e896c65222aa421d461354e3f2.
(virtio-net: fix the race between channels setting and refill)

Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/virtio_net.c