spi: spi-sh: Remove deprecated create_singlethread_workqueue
authorBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Sun, 10 Jul 2016 14:25:19 +0000 (19:55 +0530)
committerMark Brown <broonie@kernel.org>
Mon, 11 Jul 2016 18:32:38 +0000 (19:32 +0100)
commit38e099208c80b2617015385fe821b68a64757008
tree0a091c81528bc4682757142bd8bb2262f3ea2db4
parent1a695a905c18548062509178b98bc91e67510864
spi: spi-sh: Remove deprecated create_singlethread_workqueue

The workqueue has a single workitem(&ss->ws) and hence doesn't require
ordering. Also, it is not being used on a memory reclaim path. Hence, the
singlethreaded workqueue has been replaced with the use of system_wq.

System workqueues have been able to handle high level of concurrency
for a long time now and hence it's not required to have a singlethreaded
workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue
created with create_singlethread_workqueue(), system_wq allows multiple
work items to overlap executions even on the same CPU; however, a
per-cpu workqueue doesn't have any CPU locality or global ordering
guarantee unless the target CPU is explicitly specified and thus the
increase of local concurrency shouldn't make any difference.

Work item has been flushed in spi_sh_remove() to ensure that
there are no pending tasks while disconnecting the driver.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-sh.c