xfs: don't cast string literals
authorEric Sandeen <sandeen@redhat.com>
Sun, 31 May 2015 21:15:38 +0000 (07:15 +1000)
committerDave Chinner <david@fromorbit.com>
Sun, 31 May 2015 21:15:38 +0000 (07:15 +1000)
commit39e56d9219dd46d696e6a5e1e24870392154dd0f
tree637932af031b0284582db040319d33db6e1f5abb
parent7f884dc198c641c95f5c4325f0d782b1efd298b4
xfs: don't cast string literals

The commit:

a9273ca5 xfs: convert attr to use unsigned names

added these (unsigned char *) casts, but then the _SIZE macros
return "7" - size of a pointer minus one - not the length of
the string.  This is harmless in the kernel, because the _SIZE
macros are not used, but as we sync up with userspace, this will
matter.

I don't think the cast is necessary; i.e. assigning the string
literal to an unsigned char *, or passing it to a function
expecting an unsigned char *, should be ok, right?

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/libxfs/xfs_format.h