sched/autogroup: Fix race with task_groups list
authorGerald Schaefer <gerald.schaefer@de.ibm.com>
Fri, 24 May 2013 16:07:49 +0000 (18:07 +0200)
committerIngo Molnar <mingo@kernel.org>
Tue, 28 May 2013 07:40:22 +0000 (09:40 +0200)
commit41261b6a832ea0e788627f6a8707854423f9ff49
treeda525ae676d3794ff05ff7cdb9fbf2a74ca65066
parentd07e75a6e0e8582bdecefe8868b0bfbdf2ee7085
sched/autogroup: Fix race with task_groups list

In autogroup_create(), a tg is allocated and added to the task_groups
list. If CONFIG_RT_GROUP_SCHED is set, this tg is then modified while on
the list, without locking. This can race with someone walking the list,
like __enable_runtime() during CPU unplug, and result in a use-after-free
bug.

To fix this, move sched_online_group(), which adds the tg to the list,
to the end of the autogroup_create() function after the modification.

Signed-off-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1369411669-46971-2-git-send-email-gerald.schaefer@de.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/auto_group.c