nfsd: fix potential lease memory leak in nfs4_setlease
authorJeff Layton <jlayton@primarydata.com>
Fri, 22 Aug 2014 16:26:36 +0000 (12:26 -0400)
committerJeff Layton <jlayton@primarydata.com>
Tue, 7 Oct 2014 18:06:12 +0000 (14:06 -0400)
commit415b96c5a1fe31ed9deb0618e95ecbb1df3de54c
treebe4fbf6503911abac9a71fc0856c3e7a9b27e221
parentbfe8602436c803c6d5e271d52cd985d491a7470a
nfsd: fix potential lease memory leak in nfs4_setlease

It's unlikely to ever occur, but if there were already a lease set on
the file then we could end up getting back a different pointer on a
successful setlease attempt than the one we allocated. If that happens,
the one we allocated could leak.

In practice, I don't think this will happen due to the fact that we only
try to set up the lease once per nfs4_file, but this error handling is a
bit more correct given the current lease API.

Cc: J. Bruce Fields <bfields@fieldses.org>
Signed-off-by: Jeff Layton <jlayton@primarydata.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
fs/nfsd/nfs4state.c