drivers: misc: ti-st: Use int instead of fuzzy char for callback status
authorGeert Uytterhoeven <geert@linux-m68k.org>
Mon, 6 Jun 2016 09:02:03 +0000 (11:02 +0200)
committerMarcel Holtmann <marcel@holtmann.org>
Sun, 17 Jul 2016 17:59:26 +0000 (19:59 +0200)
commit4360fa22ad5b48a1d1e10e31ffb383ed8c977435
treecad6b4f9f9022fe39b74213ba11f51d5a9a228bb
parent858d68f10238fdd1ebdd0096f912f063e97c6766
drivers: misc: ti-st: Use int instead of fuzzy char for callback status

On mips and parisc:

    drivers/bluetooth/btwilink.c: In function 'ti_st_open':
    drivers/bluetooth/btwilink.c:174:21: warning: overflow in implicit constant conversion [-Woverflow]
       hst->reg_status = -EINPROGRESS;

    drivers/nfc/nfcwilink.c: In function 'nfcwilink_open':
    drivers/nfc/nfcwilink.c:396:31: warning: overflow in implicit constant conversion [-Woverflow]
      drv->st_register_cb_status = -EINPROGRESS;

There are actually two issues:
  1. Whether "char" is signed or unsigned depends on the architecture.
     As the completion callback data is used to pass a (negative) error
     code, it should always be signed.
  2. EINPROGRESS is 150 on mips, 245 on parisc.
     Hence -EINPROGRESS doesn't fit in a signed 8-bit number.

Change the callback status from "char" to "int" to fix these.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/btwilink.c
drivers/media/radio/wl128x/fmdrv_common.c
drivers/misc/ti-st/st_core.c
drivers/nfc/nfcwilink.c
include/linux/ti_wilink_st.h