efi: Use correct type for struct efi_memory_map::phys_map
authorArd Biesheuvel <ard.biesheuvel@linaro.org>
Fri, 23 Oct 2015 09:48:16 +0000 (11:48 +0200)
committerIngo Molnar <mingo@kernel.org>
Wed, 28 Oct 2015 11:28:06 +0000 (12:28 +0100)
commit44511fb9e55ada760822b0b0d7be9d150576f17f
treed6f799bbdf19e659f7d582daac03af157300b486
parent06ef431ab8060aa8ef51b36f56773d01f6a53f24
efi: Use correct type for struct efi_memory_map::phys_map

We have been getting away with using a void* for the physical
address of the UEFI memory map, since, even on 32-bit platforms
with 64-bit physical addresses, no truncation takes place if the
memory map has been allocated by the firmware (which only uses
1:1 virtually addressable memory), which is usually the case.

However, commit:

  0f96a99dab36 ("efi: Add "efi_fake_mem" boot option")

adds code that clones and modifies the UEFI memory map, and the
clone may live above 4 GB on 32-bit platforms.

This means our use of void* for struct efi_memory_map::phys_map has
graduated from 'incorrect but working' to 'incorrect and
broken', and we need to fix it.

So redefine struct efi_memory_map::phys_map as phys_addr_t, and
get rid of a bunch of casts that are now unneeded.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: izumi.taku@jp.fujitsu.com
Cc: kamezawa.hiroyu@jp.fujitsu.com
Cc: linux-efi@vger.kernel.org
Cc: matt.fleming@intel.com
Link: http://lkml.kernel.org/r/1445593697-1342-1-git-send-email-ard.biesheuvel@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/arm64/kernel/efi.c
arch/x86/platform/efi/efi.c
drivers/firmware/efi/efi.c
include/linux/efi.h