kvm: x86: Fix vmwrite to SECONDARY_VM_EXEC_CONTROL
authorHuaitong Han <huaitong.han@intel.com>
Tue, 12 Jan 2016 08:04:20 +0000 (16:04 +0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 12 Jan 2016 10:42:16 +0000 (11:42 +0100)
commit45bdbcfdf241149642fb6c25ab0c209d59c371b7
tree51e626bec2fee316a1e5cd61873c26cb725e1ab0
parentac3e5fcae8ca658e7dcc3fdcd50af7e4779f58c1
kvm: x86: Fix vmwrite to SECONDARY_VM_EXEC_CONTROL

vmx_cpuid_tries to update SECONDARY_VM_EXEC_CONTROL in the VMCS, but
it will cause a vmwrite error on older CPUs because the code does not
check for the presence of CPU_BASED_ACTIVATE_SECONDARY_CONTROLS.

This will get rid of the following trace on e.g. Core2 6600:

vmwrite error: reg 401e value 10 (err 12)
Call Trace:
[<ffffffff8116e2b9>] dump_stack+0x40/0x57
[<ffffffffa020b88d>] vmx_cpuid_update+0x5d/0x150 [kvm_intel]
[<ffffffffa01d8fdc>] kvm_vcpu_ioctl_set_cpuid2+0x4c/0x70 [kvm]
[<ffffffffa01b8363>] kvm_arch_vcpu_ioctl+0x903/0xfa0 [kvm]

Fixes: feda805fe7c4ed9cf78158e73b1218752e3b4314
Cc: stable@vger.kernel.org
Reported-by: Zdenek Kaspar <zkaspar82@gmail.com>
Signed-off-by: Huaitong Han <huaitong.han@intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/vmx.c