scsi: remove abuses of scsi_populate_tag
authorChristoph Hellwig <hch@lst.de>
Thu, 30 Oct 2014 13:30:06 +0000 (14:30 +0100)
committerChristoph Hellwig <hch@lst.de>
Wed, 12 Nov 2014 10:19:41 +0000 (11:19 +0100)
commit5066863337afdb0ad7323f424f7959d9f9f066da
tree3901d3088c8698f10e1533298ae04a98116bc395
parentabd0c533e37789ef56a73562d6d06d39897bd801
scsi: remove abuses of scsi_populate_tag

Unless we want to build a SPI tag message we should just check SCMD_TAGGED
instead of reverse engineering a tag type through the use of
scsi_populate_tag_msg.

Also rename the function to spi_populate_tag_msg, make it behave like the
other spi message helpers, and move it to the spi transport class.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Reviewed-by: Hannes Reinecke <hare@suse.de>
19 files changed:
drivers/s390/scsi/zfcp_fc.h
drivers/scsi/53c700.c
drivers/scsi/aic7xxx/aic79xx_osm.c
drivers/scsi/aic7xxx/aic7xxx_osm.c
drivers/scsi/bnx2fc/bnx2fc_io.c
drivers/scsi/csiostor/csio_scsi.c
drivers/scsi/esp_scsi.c
drivers/scsi/fnic/fnic_scsi.c
drivers/scsi/ibmvscsi/ibmvfc.c
drivers/scsi/ipr.c
drivers/scsi/lpfc/lpfc_scsi.c
drivers/scsi/pmcraid.c
drivers/scsi/qla2xxx/qla_iocb.c
drivers/scsi/qla2xxx/qla_mr.c
drivers/scsi/qla4xxx/ql4_iocb.c
drivers/scsi/scsi_transport_spi.c
drivers/scsi/tmscsim.c
include/scsi/scsi_tcq.h
include/scsi/scsi_transport_spi.h