ASoC: rt5663: refine error handling
authorArnd Bergmann <arnd@arndb.de>
Thu, 15 Sep 2016 15:42:21 +0000 (17:42 +0200)
committerMark Brown <broonie@kernel.org>
Fri, 16 Sep 2016 15:47:28 +0000 (16:47 +0100)
commit56efaed524dc2c3571f66d296cb1efbd59cb2996
treef46bd8cea3894281261b02a2ec6bbc87a7adf0c6
parentdf7c52168ee15b3951b50078c0c3960598eb0109
ASoC: rt5663: refine error handling

The newly added rt5663 codec driver introduces a couple of warnings
when built with -Wmaybe-uninitialized:

codecs/rt5663.c: In function 'rt5663_set_tdm_slot':
codecs/rt5663.c:2680:2: error: 'reg' may be used uninitialized in this function [-Werror=maybe-uninitialized]
codecs/rt5663.c: In function 'rt5663_set_dai_pll':
codecs/rt5663.c:2556:12: error: 'shift' may be used uninitialized in this function [-Werror=maybe-uninitialized]
codecs/rt5663.c:2596:2: error: 'mask' may be used uninitialized in this function [-Werror=maybe-uninitialized]

We can avoid those warnings by always returning an error
from the switch() statements instead of falling through
with an uninitialized variable when we hit an unexpected
case.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: df7c52168ee1 ("ASoC: add rt5663 codec driver")
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt5663.c