iwlwifi: mvm: don't capture firmware coredump for D3->D0 reconfig
authorJohannes Berg <johannes.berg@intel.com>
Thu, 6 Nov 2014 08:40:50 +0000 (09:40 +0100)
committerEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Tue, 11 Nov 2014 15:15:07 +0000 (17:15 +0200)
commit58629d9d6a2d67a1aa736be898ab00250701716e
tree95cb0b013f965f0de99b31b5d4f4a46c81ba0962
parent219fb66b49fac64bb87f030c133d2d32927b6fc4
iwlwifi: mvm: don't capture firmware coredump for D3->D0 reconfig

The code to capture firmware errors works during the reconfiguration
phase after an error. As the D3->D0 transition uses the same flow to
get the D0 image reconfigured, this triggered and caused a firmware
coredump to be collected. This in turn, if it isn't picked up by
userspace, can cause module unloading to fail, which is how the bug
was detected.

To fix this issue, introduce a new status flag (D3_RECONFIG) and use
it to detect that during reconfiguration no coredump should be taken
and reported.

Reported-by: Avi Kraif <avix.kraif@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
drivers/net/wireless/iwlwifi/mvm/d3.c
drivers/net/wireless/iwlwifi/mvm/mac80211.c
drivers/net/wireless/iwlwifi/mvm/mvm.h