sched: print_rq(): Don't use tasklist_lock
authorOleg Nesterov <oleg@redhat.com>
Sun, 21 Sep 2014 19:33:41 +0000 (21:33 +0200)
committerIngo Molnar <mingo@kernel.org>
Wed, 24 Sep 2014 12:47:04 +0000 (14:47 +0200)
commit5bd96ab6fef66ec6b9f54134364e618fd0f8f2f3
treeabb0e7787c12ea0a37e48277b0a6e8f11d21ce69
parent3472eaa1f12e217e2b8b0ef658ff861b2308cbbd
sched: print_rq(): Don't use tasklist_lock

read_lock_irqsave(tasklist_lock) in print_rq() looks strange. We do
not need to disable irqs, and they are already disabled by the caller.

And afaics this lock buys nothing, we can rely on rcu_read_lock().
In this case it makes sense to also move rcu_read_lock/unlock from
the caller to print_rq().

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Kirill Tkhai <tkhai@yandex.ru>
Cc: Mike Galbraith <umgwanakikbuti@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/20140921193341.GA28628@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/debug.c