tuntap: correctly handle error in tun_set_iff()
authorJason Wang <jasowang@redhat.com>
Wed, 11 Sep 2013 10:09:48 +0000 (18:09 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 12 Sep 2013 21:21:42 +0000 (17:21 -0400)
commit662ca437e714caaab855b12415d6ffd815985bc0
treec8b6eccc605fe52837e21d72bdecbf8e0c71b539
parenta9677bc024dcaafcf36c1cc4b0706b87be26ee5f
tuntap: correctly handle error in tun_set_iff()

Commit c8d68e6be1c3b242f1c598595830890b65cea64a
(tuntap: multiqueue support) only call free_netdev() on error in
tun_set_iff(). This causes several issues:

- memory of tun security were leaked
- use after free since the flow gc timer was not deleted and the tfile
  were not detached

This patch solves the above issues.

Reported-by: Wannes Rombouts <wannes.rombouts@epitech.eu>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tun.c