net: fix ethtool->set_flags not intended -EINVAL return value
authorStanislaw Gruszka <sgruszka@redhat.com>
Tue, 22 Mar 2011 23:54:49 +0000 (23:54 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Mar 2011 06:35:24 +0000 (23:35 -0700)
commit673e63c688f43104c73aad8ea4237f7ad41fa14d
tree3d11c6f74a5d0823020db8642c3f2cf062347afb
parentb5845f9834d8f4c79d324bc59b99dbcf0a40f428
net: fix ethtool->set_flags not intended -EINVAL return value

After commit d5dbda23804156ae6f35025ade5307a49d1db6d7 "ethtool: Add
support for vlan accleration.", drivers that have NETIF_F_HW_VLAN_TX,
and/or NETIF_F_HW_VLAN_RX feature, but do not allow enable/disable vlan
acceleration via ethtool set_flags, always return -EINVAL from that
function. Fix by returning -EINVAL only if requested features do not
match current settings and can not be changed by driver.

Change any driver that define ethtool->set_flags to use
ethtool_invalid_flags() to avoid similar problems in the future
(also on drivers that do not have the problem).

Tested with modified (to reproduce this bug) myri10ge driver.

Cc: stable@kernel.org # 2.6.37+
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/netxen/netxen_nic_ethtool.c
drivers/net/qlcnic/qlcnic_ethtool.c
drivers/net/s2io.c
drivers/net/vmxnet3/vmxnet3_ethtool.c
drivers/net/vxge/vxge-ethtool.c
include/linux/ethtool.h
net/core/ethtool.c