scsi: fix race between simultaneous decrements of ->host_failed
authorWei Fang <fangwei1@huawei.com>
Tue, 7 Jun 2016 06:53:56 +0000 (14:53 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 9 Jun 2016 03:08:04 +0000 (23:08 -0400)
commit72d8c36ec364c82bf1bf0c64dfa1041cfaf139f7
tree4db26e920be643a2a51d97f1d3890596201c974a
parent6b7e9cde49691e04314342b7dce90c67ad567fcc
scsi: fix race between simultaneous decrements of ->host_failed

sas_ata_strategy_handler() adds the works of the ata error handler to
system_unbound_wq. This workqueue asynchronously runs work items, so the
ata error handler will be performed concurrently on different CPUs. In
this case, ->host_failed will be decreased simultaneously in
scsi_eh_finish_cmd() on different CPUs, and become abnormal.

It will lead to permanently inequality between ->host_failed and
->host_busy, and scsi error handler thread won't start running. IO
errors after that won't be handled.

Since all scmds must have been handled in the strategy handler, just
remove the decrement in scsi_eh_finish_cmd() and zero ->host_busy after
the strategy handler to fix this race.

Fixes: 50824d6c5657 ("[SCSI] libsas: async ata-eh")
Cc: stable@vger.kernel.org
Signed-off-by: Wei Fang <fangwei1@huawei.com>
Reviewed-by: James Bottomley <jejb@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Documentation/scsi/scsi_eh.txt
drivers/ata/libata-eh.c
drivers/scsi/scsi_error.c