perf build: Fix feature-dump checks, we need to test all features
authorJiri Olsa <jolsa@redhat.com>
Thu, 28 Jan 2016 19:13:24 +0000 (16:13 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 28 Jan 2016 22:04:19 +0000 (19:04 -0300)
commit76c4aaec41b76afb7f914aaf6080f21ab331b0c6
tree87bb301bb3ece30ed0330a7244b2b50c7b6e55bc
parentcf9162c290447cdf6fca7b64dd6e2200dc52f03b
perf build: Fix feature-dump checks, we need to test all features

I see problem with test-all case speedup, because it does not
comprise checks for 32bits compilations, fix it.

The problem could be noticed by calling:

  make -C tools/perf feature-dump

That would end up misdetecting the feature-compile-x32, that, building
using 'gcc -mx32' needs stub headers not present in a fedora 23 devel
machine and thus fail to compile, but ended up appearing as detected,
i.e. present in tools/perf/FEATURE-DUMP as 'feature-compile-x32=1'.

With this fix it correctly appears as 'feature-compile-x32=0' and if we
uninstall the libc devel files for 32 bits (glibc-devel.i686), then the
relevant variable is flipped from 'feature-compile-32=1' to
'feature-compile-32=0'.

The same things happened for bionic and libbabeltrace, that were
misdetected because the are no tested in test-all.c

Reported-and-Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-u0sjaddf1r9m8icpd98ry7fz@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/build/Makefile.feature