mtd: nand: Error out if cmd_ctrl() is missing
authorAndrey Smirnov <andrew.smirnov@gmail.com>
Thu, 21 Jul 2016 21:59:20 +0000 (14:59 -0700)
committerBoris Brezillon <boris.brezillon@free-electrons.com>
Fri, 23 Sep 2016 07:35:16 +0000 (09:35 +0200)
commit76fe334f71dd20f7eadd4c624441ec7d1fb92f33
treeee8352cdd10cf0d030a9c1e8ca8296fc17946867
parent75c19e58abaed01ae20ad5802f6a6aa5a255117d
mtd: nand: Error out if cmd_ctrl() is missing

If no user specified chip->select_chip() function is provided, code in
nand_base.c will automatically set this hook to nand_select_chip(),
which in turn depends on chip->cmd_ctrl() hook being valid. Not
providing both of those functions in NAND controller driver (for example
by mistake) will result in a bit cryptic segfault. Same is true for
chip->cmdfunc().

To avoid the above scenario add a check in nand_scan_dent and error out
if cmd_ctrl() is not provided.

Suggested-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Suggested-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
drivers/mtd/nand/nand_base.c