projects / cascardo / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 2be5b3f) | patch
Revert "KVM: release anon file in failure path of vm creation"
authorPaolo Bonzini <pbonzini@redhat.com>
Thu, 14 Jul 2016 16:49:52 +0000 (18:49 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 14 Jul 2016 17:11:21 +0000 (19:11 +0200)
commit7964218c7d8fe36a79a5e02312b1f3a16a17ee68
tree8fead675d92c2fbdc180db2231fd47e6ff067984tree | snapshot
parent2be5b3f6dc84d30810cc0a94fa66205c27cf5f42commit | diff
Revert "KVM: release anon file in failure path of vm creation"

This reverts commit 77ecc085fed1af1000ca719522977b960aa6da52.

Al Viro colorfully says: "You should *NEVER* use sys_close() on failure
exit paths like that.  Moreover, this kvm_put_kvm() becomes a double-put,
since closing the damn file will drop that reference to kvm.  Please,
revert.  anon_inode_getfd() should be used only when there's no possible
failures past its call".

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
virt/kvm/kvm_main.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.