x86: Check irq_remapped instead of remapping_enabled in destroy_irq()
authorYinghai Lu <yinghai@kernel.org>
Sat, 30 Oct 2010 08:19:29 +0000 (01:19 -0700)
committerThomas Gleixner <tglx@linutronix.de>
Sat, 30 Oct 2010 08:28:31 +0000 (10:28 +0200)
commit7b79462a20826a7269322113c68ca78d5f67c0bd
treeae873a15bd5fbf47c2d75e26ebe84767ab1c94be
parent2d10d8737ccdba752d60106abbc6ed4f37404923
x86: Check irq_remapped instead of remapping_enabled in destroy_irq()

Russ Anderson reported:
| There is a regression that is causing a NULL pointer dereference
| in free_irte when shutting down xpc. git bisect narrowed it down
| to git commit d585d06(intr_remap: Simplify the code further), which
| changed free_irte(). Reverse applying the patch fixes the problem.

We need to use irq_remapped() for each irq instead of checking only
intr_remapping_enabled as there might be non remapped irqs even when
remapping is enabled.

[ tglx: use cfg instead of retrieving it again. Massaged changelog ]

Reported-bisected-and-tested-by: Russ Anderson <rja@sgi.com>
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
LKML-Reference: <4CCBD511.40607@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
arch/x86/kernel/apic/io_apic.c