hwmon: (fam15h_power) Disable preemption when reading registers
authorBorislav Petkov <bp@suse.de>
Wed, 1 Jun 2016 09:36:13 +0000 (11:36 +0200)
committerGuenter Roeck <linux@roeck-us.net>
Wed, 8 Jun 2016 03:11:10 +0000 (20:11 -0700)
commit7be4881846cfa67f968eaf5b7b50d9623a652afb
tree7c3df09b338f35577e58c44421e1d2e20795816a
parentaf8c34ce6ae32addda3788d54a7e340cad22516b
hwmon: (fam15h_power) Disable preemption when reading registers

We need to read a bunch of registers on each compute unit and possibly
on the current CPU too. Disable preemption around it. Otherwise, you
get:

  BUG: using smp_processor_id() in preemptible [00000000] code: systemd-udevd/327
  caller is read_registers+0x6a/0x110 [fam15h_power]
  CPU: 3 PID: 327 Comm: systemd-udevd Not tainted 4.7.0-rc1+ #4
  Hardware name: HP HP EliteBook 745 G3/807E, BIOS N73 Ver. 01.08 01/28/2016
  ...

Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Rui Huang <ray.huang@amd.com>
Cc: Sherry Hurwitz <sherry.hurwitz@amd.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Acked-by: Huang Rui <ray.huang@amd.com>
Tested-by: Huang Rui <ray.huang@amd.com>
Fixes: fa7943449943 ("hwmon: (fam15h_power) Add compute unit accumulated power")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/fam15h_power.c