drm/rcar: gem: dumb: pitch is an output
authorThierry Reding <treding@nvidia.com>
Mon, 3 Nov 2014 11:08:24 +0000 (12:08 +0100)
committerThierry Reding <treding@nvidia.com>
Thu, 13 Nov 2014 12:27:26 +0000 (13:27 +0100)
commit7e295a36b3af5d588e585e2300febbb191463939
tree15ecabacf9ebe9a2c0ac99e867e8f49e2e137025
parentbdb2b933f2622578b8f737ad21504eb83620024a
drm/rcar: gem: dumb: pitch is an output

When creating a dumb buffer object using the DRM_IOCTL_MODE_CREATE_DUMB
IOCTL, only the width, height, bpp and flags fields are inputs. The
caller is not guaranteed to zero out or set handle, pitch and size.
Drivers must not treat these values as possible inputs, otherwise they
may use uninitialized memory during the computation of the framebuffer
size.

The R-Car DU driver treats the pitch passed in from userspace as minimum
and will only overwrite it when the driver-computed pitch is larger,
allowing userspace to, intentionally or not, overallocate framebuffers.

Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/gpu/drm/rcar-du/rcar_du_kms.c