locks: remove i_have_this_lease check from __break_lease
authorJeff Layton <jlayton@primarydata.com>
Mon, 1 Sep 2014 18:27:43 +0000 (14:27 -0400)
committerJeff Layton <jlayton@primarydata.com>
Tue, 7 Oct 2014 18:06:13 +0000 (14:06 -0400)
commit843c6b2f4cef384af8e0de6b7ac7191675030e3a
treebd40fa64f4a6a5b4a9bcd9f37fafcb32e0efc9da
parentc45198eda2794bb72601c9f96266d8b95db66dd5
locks: remove i_have_this_lease check from __break_lease

I think that the intent of this code was to ensure that a process won't
deadlock if it has one fd open with a lease on it and then breaks that
lease by opening another fd. In that case it'll treat the __break_lease
call as if it were non-blocking.

This seems wrong -- the process could (for instance) be multithreaded
and managing different fds via different threads. I also don't see any
mention of this limitation in the (somewhat sketchy) documentation.

Remove the check and the non-blocking behavior when i_have_this_lease
is true.

Signed-off-by: Jeff Layton <jlayton@primarydata.com>
fs/locks.c