[media] media: stk1160: Avoid stack-allocated buffer for control URBs
authorEzequiel Garcia <ezequiel.garcia@free-electrons.com>
Thu, 17 Apr 2014 12:28:20 +0000 (09:28 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Sat, 24 May 2014 20:12:11 +0000 (17:12 -0300)
commit85ac1a1772bb41da895bad83a81f6a62c8f293f6
treed491a04c51f663061fb9f7c968e2dbb1351e18fb
parent8774bed9ce832d8d9ccb79e92800b808aa2d2ad2
[media] media: stk1160: Avoid stack-allocated buffer for control URBs

Currently stk1160_read_reg() uses a stack-allocated char to get the
read control value. This is wrong because usb_control_msg() requires
a kmalloc-ed buffer.

This commit fixes such issue by kmalloc'ating a 1-byte buffer to receive
the read value.

While here, let's remove the urb_buf array which was meant for a similar
purpose, but never really used.

Cc: Alan Stern <stern@rowland.harvard.edu>
Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Cc: stable@vger.kernel.org # for v3.7 and up
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/usb/stk1160/stk1160-core.c
drivers/media/usb/stk1160/stk1160.h