backlight: adp88x0: Fix uninitialized variable use
authorArnd Bergmann <arnd@arndb.de>
Mon, 23 Nov 2015 13:44:13 +0000 (14:44 +0100)
committerLee Jones <lee.jones@linaro.org>
Mon, 11 Jan 2016 05:56:12 +0000 (05:56 +0000)
commit86c68e2fb3eeb87ef716a0d61c5a346e9aee2ecb
treec356db3958377c49ef83c175c8eb697d49105da5
parent1ec218373b8ebda821aec00bb156a9c94fad9cd4
backlight: adp88x0: Fix uninitialized variable use

gcc correctly warns about both the adp8860 and adp8870 backlight
drivers using an uninitialized variable in their error handling
path:

drivers/video/backlight/adp8870_bl.c: In function 'adp8870_bl_ambient_light_zone_store':
drivers/video/backlight/adp8870_bl.c:811:11: warning: 'reg_val' may be used uninitialized in this function

This changes the code to only write back the data if it was
correctly read to start with.

As a side-note, the drivers are mostly identical, so I think they
should really be merged into one file to avoid having to fix every
bug twice.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/video/backlight/adp8860_bl.c
drivers/video/backlight/adp8870_bl.c