ASoC: tlv320dac33: Remove deprecated create_singlethread_workqueue
authorBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Sun, 4 Sep 2016 15:57:32 +0000 (21:27 +0530)
committerMark Brown <broonie@kernel.org>
Wed, 14 Sep 2016 15:33:55 +0000 (16:33 +0100)
commit8891098246d07e6dda964a0cffbd504de566c4c3
treee169bce41875eacfbc21faa8c12067fead5241ad
parent29b4817d4018df78086157ea3a55c1d9424a7cfc
ASoC: tlv320dac33: Remove deprecated create_singlethread_workqueue

The workqueue "dac33_wq" queues a single work item &dac33->work and
hence doesn't require ordering. Also, it is not being used on a memory
reclaim path. Hence, it has been converted to use system_wq.

System workqueues have been able to handle high level of concurrency
for a long time now and hence it's not required to have a singlethreaded
workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue
created with create_singlethread_workqueue(), system_wq allows multiple
work items to overlap executions even on the same CPU; however, a
per-cpu workqueue doesn't have any CPU locality or global ordering
guarantee unless the target CPU is explicitly specified and thus the
increase of local concurrency shouldn't make any difference.

The work item has been flushed in dac33_soc_remove to ensure that
there are no pending tasks while disconnecting the driver.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/tlv320dac33.c