Merge branch 'sctp-fix-gap-ack-blocks'
authorDavid S. Miller <davem@davemloft.net>
Fri, 23 Sep 2016 10:55:04 +0000 (06:55 -0400)
committerDavid S. Miller <davem@davemloft.net>
Fri, 23 Sep 2016 10:55:04 +0000 (06:55 -0400)
commit88e4f75900368b8a6febb7bc7d379d52d02e920d
treeee337cdd7533abaf1e538a188184307c1de021f0
parent21641c2e1ffd0b504610a33beaeab8fcc5140677
parent182691d0998400f35ad304718024e60feaa864aa
Merge branch 'sctp-fix-gap-ack-blocks'

Marcelo Ricardo Leitner says:

====================
sctp: fix the handling of SACK Gap Ack blocks

sctp_acked() is using 32bit arithmetics on 16bits vars, via TSN_lte()
macros, which is weird and confusing.

Once the offset to ctsn is calculated, all wrapping is already handled
and thus to verify the Gap Ack blocks we can just use pure
less/big-or-equal than checks.

Also, rename gap variable to tsn_offset, so it's more meaningful, as
it doesn't point to any gap at all.

Even so, I don't think this discrepancy resulted in any practical bug.

This patch is a preparation for the next one, which will introduce
typecheck() for TSN_lte() macros and would cause a compile error here.

Suggested-by: David Laight <David.Laight@ACULAB.COM>
Reported-by: David Laight <David.Laight@ACULAB.COM>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
====================

Signed-off-by: David S. Miller <davem@davemloft.net>