fs/super.c: fix race between freeze_super() and thaw_super()
authorOleg Nesterov <oleg@redhat.com>
Mon, 26 Sep 2016 16:07:48 +0000 (18:07 +0200)
committerAl Viro <viro@zeniv.linux.org.uk>
Sat, 15 Oct 2016 00:00:34 +0000 (20:00 -0400)
commit89f39af129382a40d7cd1f6914617282cfeee28e
tree01c7ce34eda659481fba92293365b3a07c725d16
parent655042cc1406fcec20aa7ffd7d790ada18ac5211
fs/super.c: fix race between freeze_super() and thaw_super()

Change thaw_super() to check frozen != SB_FREEZE_COMPLETE rather than
frozen == SB_UNFROZEN, otherwise it can race with freeze_super() which
drops sb->s_umount after SB_FREEZE_WRITE to preserve the lock ordering.

In this case thaw_super() will wrongly call s_op->unfreeze_fs() before
it was actually frozen, and call sb_freeze_unlock() which leads to the
unbalanced percpu_up_write(). Unfortunately lockdep can't detect this,
so this triggers misc BUG_ON()'s in kernel/rcu/sync.c.

Reported-and-tested-by: Nikolay Borisov <kernel@kyup.com>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/super.c