mtd: physmap_of: fix potential NULL dereference
authorArd Biesheuvel <ard.biesheuvel@linaro.org>
Sun, 30 Nov 2014 12:51:03 +0000 (13:51 +0100)
committerBrian Norris <computersforpeace@gmail.com>
Sat, 13 Dec 2014 03:12:16 +0000 (19:12 -0800)
commit92b633a8a482c4bc1ff3b7cffdcace7836861554
tree7b64321201ddde6d9cd049851039156d3221a39b
parent58c81957b7d284c57a9fc1b815c77155ef744ea5
mtd: physmap_of: fix potential NULL dereference

On device remove, when testing the cmtd field of an of_flash
struct to decide whether it is a concatenated device or not,
we get a false positive on cmtd == NULL, and dereference it
subsequently. This may occur if of_flash_remove() is called
from the cleanup path of of_flash_probe().

Instead, test for NULL first, and only then perform the test
for a concatenated device.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
drivers/mtd/maps/physmap_of.c