powerpc/mpic_msgr: Use kcalloc and correct the argument to sizeof
authorHimangi Saraogi <himangi774@gmail.com>
Sat, 19 Jul 2014 21:53:35 +0000 (03:23 +0530)
committerScott Wood <scottwood@freescale.com>
Wed, 30 Jul 2014 00:26:31 +0000 (19:26 -0500)
commit983e2444100667b4b35c9d56c9a1fec1e817143c
tree8dbd5f0244c65cda464e0eef3ffc9477f1cb1aef
parent54afbec0d57f322127e3886b04fe4fd860519bfb
powerpc/mpic_msgr: Use kcalloc and correct the argument to sizeof

mpic_msgrs has type struct mpic_msgr **, not struct mpic_msgr *, so the
elements of the array should have pointer type, not structure type.
The advantage of kcalloc is, that will prevent integer overflows which
could result from the multiplication of number of elements and size and
it is also a bit nicer to read.

The Coccinelle semantic patch that makes the first change is as follows:

// <smpl>
@disable sizeof_type_expr@
type T;
T **x;
@@

  x =
  <+...sizeof(
- T
+ *x
  )...+>
// </smpl>

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Scott Wood <scottwood@freescale.com>
arch/powerpc/sysdev/mpic_msgr.c