tracing/kprobes: unregister_trace_probe needs to be called under mutex
authorSrikar Dronamraju <srikar@linux.vnet.ibm.com>
Wed, 30 Jun 2010 08:45:48 +0000 (14:15 +0530)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 4 Aug 2010 15:41:23 +0000 (12:41 -0300)
commit9da79ab83ee33ddc1fdd0858fd3d70925a1bde99
tree116f9d3c256a91ede964ebbfd3779949cc5953d4
parentb83f920e179101a54721e5ab1d6c3edfb9d4bcbb
tracing/kprobes: unregister_trace_probe needs to be called under mutex

Comment in unregister_trace_probe() says probe_lock will be held when it
gets called. However there is a case where it might called without the
probe_lock being held. Also since we are traversing the probe_list and
deleting an element from the probe_list, probe_lock should be held.

This was first pointed in uprobes traceevent review by Frederic
Weisbecker here.  (http://lkml.org/lkml/2010/5/12/106)

Cc: Ingo Molnar <mingo@elte.hu>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
LKML-Reference: <20100630084548.GA10325@linux.vnet.ibm.com>
Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
kernel/trace/trace_kprobe.c