mtd: nand: expand nand_ecc_layout, deprecate ioctl ECCGETLAYOUT
authorBrian Norris <computersforpeace@gmail.com>
Wed, 25 Aug 2010 01:12:00 +0000 (18:12 -0700)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Sun, 24 Oct 2010 22:37:24 +0000 (23:37 +0100)
commitcc26c3cd3d1cf40a07f2b19ac4c53d517bee52a5
tree664c422944f780a1cc99f872714eeb339efef7ef
parentf4a2da0cd522a3b805ff2386c14912945bf990c7
mtd: nand: expand nand_ecc_layout, deprecate ioctl ECCGETLAYOUT

struct nand_ecclayout is too small for many new chips; OOB regions can be as
large as 448 bytes and may increase more in the future. Thus, copying that
struct to user-space with the ECCGETLAYOUT ioctl is not a good idea; the ioctl
would have to be updated every time there's a change to the current largest
size.

Instead, the old nand_ecclayout is renamed to nand_ecclayout_user and a
new struct nand_ecclayout is created that can accomodate larger sizes and
expand without affecting the user-space. struct nand_ecclayout can still
be used in board drivers without modification -- at least for now.

A new function is provided to convert from the new to the old in order to
allow the deprecated ioctl to continue to work with truncated data. Perhaps
the ioctl, the conversion process, and the struct nand_ecclayout_user can be
removed altogether in the future.

Note: There are comments in nand/davinci_nand.c::nand_davinci_probe()
regarding this issue; this driver (and maybe others) can be updated to
account for extra space. All kernel drivers can use the expanded
nand_ecclayout as a drop-in replacement and ignore its benefits.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
drivers/mtd/mtdchar.c
drivers/mtd/nand/davinci_nand.c
include/linux/mtd/mtd.h
include/linux/mtd/partitions.h
include/mtd/mtd-abi.h
include/mtd/mtd-user.h