trace: Don't use __weak in header files
authorStephen Rothwell <sfr@canb.auug.org.au>
Thu, 12 Mar 2015 05:58:34 +0000 (16:58 +1100)
committerSteven Rostedt <rostedt@goodmis.org>
Wed, 25 Mar 2015 12:57:23 +0000 (08:57 -0400)
commitd9a16d3ab8770357015c85a07387f1d2676a4773
treedda7ffadc88f05c45f121074103a4c0e09c7f57e
parent754cb0071a5c9576ccfa6523969ef6a2f6a71676
trace: Don't use __weak in header files

The commit that added a check for this to checkpatch says:

"Using weak declarations can have unintended link defects.  The __weak on
the declaration causes non-weak definitions to become weak."

In this case, when a PowerPC kernel is built with CONFIG_KPROBE_EVENT
but not CONFIG_UPROBE_EVENT, it generates the following warning:

WARNING: 1 bad relocations
c0000000014f2190 R_PPC64_ADDR64    uprobes_fetch_type_table

This is fixed by passing the fetch_table arrays to
traceprobe_parse_probe_arg() which also means that they can never be NULL.

Link: http://lkml.kernel.org/r/20150312165834.4482cb48@canb.auug.org.au
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace_kprobe.c
kernel/trace/trace_probe.c
kernel/trace/trace_probe.h
kernel/trace/trace_uprobe.c