ALSA: hda/ca0132 - Don't try loading firmware at resume when already failed
authorTakashi Iwai <tiwai@suse.de>
Sun, 10 Aug 2014 11:30:08 +0000 (13:30 +0200)
committerTakashi Iwai <tiwai@suse.de>
Sun, 10 Aug 2014 11:30:08 +0000 (13:30 +0200)
commite24aa0a4c5ac92a171d9dd74a8d3dbf652990d36
tree330d205ad7d7a25243266672195bda4b894a1c42
parentde3da4f696b473e7810bd9837c18bf9fd30a9a6d
ALSA: hda/ca0132 - Don't try loading firmware at resume when already failed

CA0132 driver tries to reload the firmware at resume.  Usually this
works since the firmware loader core caches the firmware contents by
itself.  However, if the driver failed to load the firmwares
(e.g. missing files), reloading the firmware at resume goes through
the actual file loading code path, and triggers a kernel WARNING like:

 WARNING: CPU: 10 PID:11371 at drivers/base/firmware_class.c:1105 _request_firmware+0x9ab/0x9d0()

For avoiding this situation, this patch makes CA0132 skipping the f/w
loading at resume when it failed at probe time.

Reported-and-tested-by: Janek Kozicki <cosurgi@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_ca0132.c