[media] au0828: Fix dev_state handling
authorMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 22 Mar 2016 12:21:57 +0000 (09:21 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Thu, 31 Mar 2016 18:01:35 +0000 (15:01 -0300)
commite8e3039f5b941f7825d335f8ca11c12a8104db11
treec5a83551b6f871ed83fb42f23c5a4ebef9bca1cb
parented940cd27416f9887864b95e1f8f8845aa9d6391
[media] au0828: Fix dev_state handling

The au0828 dev_state is actually a bit mask. It should not be
checking with "==" but, instead, with a logic and. There are some
places where it was doing it wrong.

Fix that by replacing the dev_state set/clear/test with the
bitops.

As reviewed by Shuah:
"Looks good. Tested running bind/unbind au0828 loop for 1000 times.
Didn't see any problems and the v4l2_querycap() problem has been
fixed with this patch.

After the above test, ran bind/unbind snd_usb_audio 1000 times.
Didn't see any problems. Generated media graph and the graph
looks good."

Cc: stable@vger.kernel.org
Reviewed-by: Shuah Khan <shuahkh@osg.samsung.com>
Tested-by: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/usb/au0828/au0828-core.c
drivers/media/usb/au0828/au0828-input.c
drivers/media/usb/au0828/au0828-video.c
drivers/media/usb/au0828/au0828.h