SUNRPC: Fix a deadlock in rpc_client_register()
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Wed, 10 Jul 2013 19:33:01 +0000 (15:33 -0400)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Wed, 10 Jul 2013 19:58:55 +0000 (15:58 -0400)
commiteeee245268c951262b861bc1be4e9dc812352499
tree055c5d4ea0406bbb5457052ee85148b5f9746cf7
parent4f8568cb5290295c384d5c1328c52790e33a8a0d
SUNRPC: Fix a deadlock in rpc_client_register()

Commit 384816051ca9125cd54750e59c780c2a2655fa4f (SUNRPC: fix races on
PipeFS MOUNT notifications) introduces a regression when we call
rpc_setup_pipedir() with RPCSEC_GSS as the auth flavour.

By calling rpcauth_create() while holding the sn->pipefs_sb_lock, we
end up deadlocking in gss_pipes_dentries_create_net().
Fix is to register the client and release the mutex before calling
rpcauth_create().

Reported-by: Weston Andros Adamson <dros@netapp.com>
Tested-by: Weston Andros Adamson <dros@netapp.com>
Cc: Stanislav Kinsbursky <skinsbursky@parallels.com>
Cc: <stable@vger.kernel.org> # : 3848160: SUNRPC: fix races on PipeFS MOUNT
Cc: <stable@vger.kernel.org> # : e73f4cc: SUNRPC: split client creation
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
net/sunrpc/clnt.c