uprobes: Kill the pointless inode/uc checks in register/unregister
authorOleg Nesterov <oleg@redhat.com>
Wed, 21 Nov 2012 17:01:43 +0000 (18:01 +0100)
committerOleg Nesterov <oleg@redhat.com>
Fri, 8 Feb 2013 16:47:01 +0000 (17:47 +0100)
commitf0744af7d0fde190674064c54e2ff60b34ac71fe
tree1fbe365e02f6d11c1a8837689578ef9b0874f0fa
parentbbc33d05930f870ea049eae5ed980f8b827d0813
uprobes: Kill the pointless inode/uc checks in register/unregister

register/unregister verifies that inode/uc != NULL. For what?
This really looks like "hide the potential problem", the caller
should pass the valid data.

register() also checks uc->next == NULL, probably to prevent the
double-register but the caller can do other stupid/wrong things.
If we do this check, then we should document that uc->next should
be cleared before register() and add BUG_ON().

Also add the small comment about the i_size_read() check.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
kernel/events/uprobes.c