myri10ge: fix error return code
authorJulia Lawall <julia.lawall@lip6.fr>
Mon, 29 Dec 2014 17:04:37 +0000 (18:04 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 1 Jan 2015 00:19:00 +0000 (19:19 -0500)
commitf12e77caf6c21588d6b24b5f1d8a6036f9ff9378
tree651c84d729996157c41a89149961e6fb8061a7e0
parent8a0a1f840f6cc09c20963b1938cb3c976378783d
myri10ge: fix error return code

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

The patch also modifies the test of mgp->cmd to satisfy checkpatch.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/myricom/myri10ge/myri10ge.c