Revert "drm/fb-helper: Reduce READ_ONCE(master) to lockless_dereference"
authorJohannes Berg <johannes.berg@intel.com>
Thu, 11 Aug 2016 09:50:21 +0000 (11:50 +0200)
committerIngo Molnar <mingo@kernel.org>
Thu, 18 Aug 2016 13:36:13 +0000 (15:36 +0200)
commitf17b3ea3d2df7c9bf3ce1dbd65b5fd7061f8e787
tree5d09e44a82d1aac1bb0658aefbba3bfee90e561c
parent3684b03d8e9a889eda94ee74421959a9d55e5e19
Revert "drm/fb-helper: Reduce READ_ONCE(master) to lockless_dereference"

This reverts commit:

  fa7d81bb3c269 ("drm/fb-helper: Reduce READ_ONCE(master) to lockless_dereference")

As Peter explained:

  [...] lockless_dereference() is _stronger_ than READ_ONCE(), not weaker.

  [...]

  Also, clue is in the name: 'dereference', you don't actually dereference
  the pointer here, only load it.

My next patch breaks the compile without this revert, because it assumes
you want to deference and thus also need the struct type visible (which
it isn't here), so revert it.

Tested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1470909022-687-1-git-send-email-johannes@sipsolutions.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
drivers/gpu/drm/drm_fb_helper.c