xfs: fix btree cursor error cleanups
authorBrian Foster <bfoster@redhat.com>
Wed, 19 Aug 2015 00:00:53 +0000 (10:00 +1000)
committerDave Chinner <david@fromorbit.com>
Wed, 19 Aug 2015 00:00:53 +0000 (10:00 +1000)
commitf307080a626569f89bc8fbad9f936b307aded877
tree1a9755621f7feadb480312954565d5d91bf5c704
parent0ae120f8a81a8dc4f974d0819c97b58c4fa935ac
xfs: fix btree cursor error cleanups

The btree cursor cleanup function takes an error parameter that
affects how buffers are released from the cursor. All buffers are
released in the event of error. Several callers do not specify the
XFS_BTREE_ERROR flag in the event of error, however. This can cause
buffers to hang around locked or with an elevated hold count and
thus lead to umount hangs in the event of errors.

Fix up the xfs_btree_del_cursor() callers to pass XFS_BTREE_ERROR if
the cursor is being torn down due to error.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/libxfs/xfs_ialloc.c
fs/xfs/xfs_itable.c