sched/dl: Fix preemption checks
authorKirill Tkhai <ktkhai@parallels.com>
Tue, 21 Oct 2014 16:35:56 +0000 (20:35 +0400)
committerIngo Molnar <mingo@kernel.org>
Tue, 28 Oct 2014 09:46:10 +0000 (10:46 +0100)
commitf3a7e1a9c464a32ee186ab91388313c82e7ce018
tree74d90ab7172a01aa653b88570322eb900789a562
parentfcd964dda5ece2fa77f78f843bc3455348787282
sched/dl: Fix preemption checks

1) switched_to_dl() check is wrong. We reschedule only
   if rq->curr is deadline task, and we do not reschedule
   if it's a lower priority task. But we must always
   preempt a task of other classes.

2) dl_task_timer():
   Policy does not change in case of priority inheritance.
   rt_mutex_setprio() changes prio, while policy remains old.

So we lose some balancing logic in dl_task_timer() and
switched_to_dl() when we check policy instead of priority. Boosted
task may be rq->curr.

(I didn't change switched_from_dl() because no check is necessary
there at all).

I've looked at this place(switched_to_dl) several times and even fixed
this function, but found just now...  I suppose some performance tests
may work better after this.

Signed-off-by: Kirill Tkhai <ktkhai@parallels.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Juri Lelli <juri.lelli@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/1413909356.19914.128.camel@tkhai
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/deadline.c