mac80211: fix AP_VLAN crypto tailroom calculation
authorMichal Kazior <michal.kazior@tieto.com>
Wed, 13 May 2015 09:16:48 +0000 (09:16 +0000)
committerJohannes Berg <johannes.berg@intel.com>
Wed, 20 May 2015 13:10:11 +0000 (15:10 +0200)
commitf9dca80b98caac8b4bfb43a2edf1e9f877ccf322
tree121584d758c7c1425dce7d87393ed4ca37f7de79
parent252ec2b3aa6f6a9ac29c6539027db600c11bf45e
mac80211: fix AP_VLAN crypto tailroom calculation

Some splats I was seeing:

 (a) WARNING: CPU: 1 PID: 0 at /devel/src/linux/net/mac80211/wep.c:102 ieee80211_wep_add_iv
 (b) WARNING: CPU: 1 PID: 0 at /devel/src/linux/net/mac80211/wpa.c:73 ieee80211_tx_h_michael_mic_add
 (c) WARNING: CPU: 3 PID: 0 at /devel/src/linux/net/mac80211/wpa.c:433 ieee80211_crypto_ccmp_encrypt

I've seen (a) and (b) with ath9k hw crypto and (c)
with ath9k sw crypto. All of them were related to
insufficient skb tailroom and I was able to
trigger these with ping6 program.

AP_VLANs may inherit crypto keys from parent AP.
This wasn't considered and yielded problems in
some setups resulting in inability to transmit
data because mac80211 wouldn't resize skbs when
necessary and subsequently drop some packets due
to insufficient tailroom.

For efficiency purposes don't inspect both AP_VLAN
and AP sdata looking for tailroom counter. Instead
update AP_VLAN tailroom counters whenever their
master AP tailroom counter changes.

Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/iface.c
net/mac80211/key.c
net/mac80211/key.h
net/mac80211/util.c