PM / hibernate: Avoid overflow in hibernate_preallocate_memory()
authorAaron Lu <aaron.lu@intel.com>
Wed, 6 Nov 2013 00:41:31 +0000 (08:41 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 7 Nov 2013 00:58:39 +0000 (01:58 +0100)
commitfd432b9f8c7c88428a4635b9f5a9c6e174df6e36
treee26cc46d07634fbccc9d6ac5bf188e53232a828e
parent7bc9b1cffc95675a957e870d258e95d43dcbba0b
PM / hibernate: Avoid overflow in hibernate_preallocate_memory()

When system has a lot of highmem (e.g. 16GiB using a 32 bits kernel),
the code to calculate how much memory we need to preallocate in
normal zone may cause overflow. As Leon has analysed:

 It looks that during computing 'alloc' variable there is overflow:
 alloc = (3943404 - 1970542) - 1978280 = -5418 (signed)
 And this function goes to err_out.

Fix this by avoiding that overflow.

References: https://bugzilla.kernel.org/show_bug.cgi?id=60817
Reported-and-tested-by: Leon Drugi <eyak@wp.pl>
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Aaron Lu <aaron.lu@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
kernel/power/snapshot.c