sctp: Remove some redundant code

In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call
to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was
hidden in 'sctp_skb_list_tail()'

Now, the code around it looks redundant. The '_init()' part of
'skb_queue_splice_tail_init()' should already do the same.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/sctp/ulpqueue.c b/net/sctp/ulpqueue.c
index 877e550..84d0fda 100644 (file)
--- a/net/sctp/ulpqueue.c
+++ b/net/sctp/ulpqueue.c
@@ -140,11 +140,8 @@ int sctp_clear_pd(struct sock *sk, struct sctp_association *asoc)
                 * we can go ahead and clear out the lobby in one shot
                 */
                if (!skb_queue_empty(&sp->pd_lobby)) {
-                       struct list_head *list;
                        skb_queue_splice_tail_init(&sp->pd_lobby,
                                                   &sk->sk_receive_queue);
-                       list = (struct list_head *)&sctp_sk(sk)->pd_lobby;
-                       INIT_LIST_HEAD(list);
                        return 1;
                }
        } else {