From: Andreas Gruenbacher Date: Mon, 9 May 2016 11:28:49 +0000 (+0200) Subject: xattr: Fail with -EINVAL for NULL attribute names X-Git-Tag: v4.7-rc1~51^2~1 X-Git-Url: http://git.cascardo.info/?p=cascardo%2Flinux.git;a=commitdiff_plain;h=aaf431b4f92152d46ab54079692633aa422262b1 xattr: Fail with -EINVAL for NULL attribute names Commit 98e9cb57 improved the xattr name checks in xattr_resolve_name but didn't update the NULL attribute name check appropriately, so NULL attribute names lead to NULL pointer dereferences. Turn that into -EINVAL results instead. Signed-off-by: Andreas Gruenbacher fs/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Signed-off-by: Al Viro --- diff --git a/fs/xattr.c b/fs/xattr.c index b11945e15fde..4231488f2122 100644 --- a/fs/xattr.c +++ b/fs/xattr.c @@ -668,7 +668,7 @@ xattr_resolve_name(const struct xattr_handler **handlers, const char **name) const struct xattr_handler *handler; if (!*name) - return NULL; + return ERR_PTR(-EINVAL); for_each_xattr_handler(handlers, handler) { const char *n;