From: Bartosz Golaszewski Date: Mon, 12 Jan 2015 13:47:22 +0000 (+0100) Subject: hwmon: (ina2xx) use DIV_ROUND_CLOSEST() to avoid rounding errors X-Git-Tag: v4.0-rc1~169^2~11 X-Git-Url: http://git.cascardo.info/?p=cascardo%2Flinux.git;a=commitdiff_plain;h=b721fe2a3a92b896ba1b41e338471dfef672052a hwmon: (ina2xx) use DIV_ROUND_CLOSEST() to avoid rounding errors Use DIV_ROUND_CLOSEST() when dealing with the calibration values to make the calculations less error prone. Signed-off-by: Bartosz Golaszewski Signed-off-by: Guenter Roeck --- diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c index ae110c5386ae..611ec4edd979 100644 --- a/drivers/hwmon/ina2xx.c +++ b/drivers/hwmon/ina2xx.c @@ -186,8 +186,11 @@ static void ina226_set_update_interval(struct ina2xx_data *data) static int ina2xx_calibrate(struct ina2xx_data *data) { - return i2c_smbus_write_word_swapped(data->client, INA2XX_CALIBRATION, - data->config->calibration_factor / data->rshunt); + u16 val = DIV_ROUND_CLOSEST(data->config->calibration_factor, + data->rshunt); + + return i2c_smbus_write_word_swapped(data->client, + INA2XX_CALIBRATION, val); } /* @@ -307,7 +310,8 @@ static int ina2xx_get_value(struct ina2xx_data *data, u8 reg) val = (s16)data->regs[reg]; break; case INA2XX_CALIBRATION: - val = data->config->calibration_factor / data->regs[reg]; + val = DIV_ROUND_CLOSEST(data->config->calibration_factor, + data->regs[reg]); break; default: /* programmer goofed */